-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracestate): drop right-most member in tracestate #2592
Merged
MrAlias
merged 11 commits into
open-telemetry:main
from
1046102779:feature/tracestate0209
Feb 23, 2022
Merged
fix(tracestate): drop right-most member in tracestate #2592
MrAlias
merged 11 commits into
open-telemetry:main
from
1046102779:feature/tracestate0209
Feb 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1046102779 <seachen@tencent.com>
1046102779
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
February 9, 2022 02:06
1046102779
changed the title
todo(tracestate): drop right-most member in tracestate
fix(tracestate): drop right-most member in tracestate
Feb 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #2592 +/- ##
=====================================
Coverage 76.1% 76.2%
=====================================
Files 173 173
Lines 12234 12227 -7
=====================================
+ Hits 9318 9324 +6
+ Misses 2673 2662 -11
+ Partials 243 241 -2
|
dmathieu
reviewed
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a changelog entry
Signed-off-by: 1046102779 <seachen@tencent.com>
Signed-off-by: 1046102779 <seachen@tencent.com>
MrAlias
reviewed
Feb 9, 2022
Signed-off-by: 1046102779 <seachen@tencent.com>
MrAlias
reviewed
Feb 16, 2022
Signed-off-by: 1046102779 <seachen@tencent.com>
Signed-off-by: 1046102779 <seachen@tencent.com>
MrAlias
reviewed
Feb 17, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Feb 22, 2022
MadVikingGod
approved these changes
Feb 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 1046102779 seachen@tencent.com
w3c/trace-context#448