Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracestate): drop right-most member in tracestate #2592

Merged
merged 11 commits into from
Feb 23, 2022

Conversation

1046102779
Copy link
Contributor

Signed-off-by: 1046102779 seachen@tencent.com

w3c/trace-context#448

Signed-off-by: 1046102779 <seachen@tencent.com>
@1046102779 1046102779 changed the title todo(tracestate): drop right-most member in tracestate fix(tracestate): drop right-most member in tracestate Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #2592 (1e68deb) into main (d51d1b3) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2592   +/-   ##
=====================================
  Coverage   76.1%   76.2%           
=====================================
  Files        173     173           
  Lines      12234   12227    -7     
=====================================
+ Hits        9318    9324    +6     
+ Misses      2673    2662   -11     
+ Partials     243     241    -2     
Impacted Files Coverage Δ
trace/tracestate.go 100.0% <100.0%> (ø)
exporters/jaeger/jaeger.go 93.5% <0.0%> (+0.8%) ⬆️
sdk/metric/sdk.go 81.5% <0.0%> (+1.4%) ⬆️
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+20.0%) ⬆️

Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a changelog entry

trace/tracestate_test.go Show resolved Hide resolved
Signed-off-by: 1046102779 <seachen@tencent.com>
Signed-off-by: 1046102779 <seachen@tencent.com>
trace/tracestate.go Show resolved Hide resolved
trace/tracestate.go Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
trace/tracestate.go Show resolved Hide resolved
trace/tracestate.go Outdated Show resolved Hide resolved
1046102779 and others added 2 commits February 18, 2022 09:32
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit 94b1848 into open-telemetry:main Feb 23, 2022
@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 24, 2022
@MrAlias MrAlias mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants